Skip to content

fix map source mapping#778

Merged
JoelLefkowitz merged 1 commit intoaxnsan12:1.21.xfrom
PetrDlouhy:master
Jul 14, 2022
Merged

fix map source mapping#778
JoelLefkowitz merged 1 commit intoaxnsan12:1.21.xfrom
PetrDlouhy:master

Conversation

@PetrDlouhy
Copy link
Copy Markdown
Contributor

There is mistake in link to the map js file which causes whitenoise in Djago 4.0 to fail with error:

Post-processing 'drf-yasg/redoc-old/redoc.min.js' failed!

Traceback (most recent call last):
  File "/home/petr/soubory/programovani/blenderkit/blenderhub_server/./manage.py", line 23, in <module>
    execute_from_command_line(sys.argv)
  File "/home/petr/.cache/pypoetry/virtualenvs/blenderkit-server-eqrfB9dY-py3.9/lib/python3.9/site-packages/django/core/management/__init__.py", line 425, in execute_from_command_line
    utility.execute()
  File "/home/petr/.cache/pypoetry/virtualenvs/blenderkit-server-eqrfB9dY-py3.9/lib/python3.9/site-packages/django/core/management/__init__.py", line 419, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/petr/.cache/pypoetry/virtualenvs/blenderkit-server-eqrfB9dY-py3.9/lib/python3.9/site-packages/django/core/management/base.py", line 373, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/petr/.cache/pypoetry/virtualenvs/blenderkit-server-eqrfB9dY-py3.9/lib/python3.9/site-packages/django/core/management/base.py", line 417, in execute
    output = self.handle(*args, **options)
  File "/home/petr/.cache/pypoetry/virtualenvs/blenderkit-server-eqrfB9dY-py3.9/lib/python3.9/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 187, in handle
    collected = self.collect()
  File "/home/petr/.cache/pypoetry/virtualenvs/blenderkit-server-eqrfB9dY-py3.9/lib/python3.9/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 134, in collect
    raise processed
whitenoise.storage.MissingFileError: The file 'drf-yasg/redoc-old/redoc.min.map' could not be found with <whitenoise.storage.CompressedManifestStaticFilesStorage object at 0x7fd7578b2e80>.

The JS file 'drf-yasg/redoc-old/redoc.min.js' references a file which could not be found:
  drf-yasg/redoc-old/redoc.min.map

This MR fixes that.

@PavanTatikonda
Copy link
Copy Markdown

PavanTatikonda commented Mar 29, 2022

@PetrDlouhy @axnsan12 Could you please help with the next steps for this fix and make new PyPI release ?

@PetrDlouhy
Copy link
Copy Markdown
Contributor Author

@PavanTatikonda What steps could I do? I don't have any rights to this GitHub nor the PyPI repository.

@PavanTatikonda
Copy link
Copy Markdown

@PavanTatikonda What steps could I do? I don't have any rights to this GitHub nor the PyPI repository.

@PetrDlouhy Oh ok, it looks like only @axnsan12 has permissions to cut a new release then.
Anyway, thanks for providing the fix here!

@keyvanm
Copy link
Copy Markdown

keyvanm commented Apr 19, 2022

Hey guys, bumping this. If this PR fixes #761 can we get it merged in?

@pandafy
Copy link
Copy Markdown
Contributor

pandafy commented Jun 7, 2022

@axnsan12 ping!

@hardikns
Copy link
Copy Markdown

hardikns commented Jun 8, 2022

Can we pls get this in? @axnsan12

@Oksamies
Copy link
Copy Markdown

Maybe @JoelLefkowitz can merge this?

@JoelLefkowitz
Copy link
Copy Markdown
Collaborator

Maybe @JoelLefkowitz can merge this?

I'll take a look, thanks for flagging

@JoelLefkowitz JoelLefkowitz changed the base branch from master to 1.21.x July 14, 2022 16:11
@JoelLefkowitz JoelLefkowitz merged commit fc4d6a1 into axnsan12:1.21.x Jul 14, 2022
@JoelLefkowitz
Copy link
Copy Markdown
Collaborator

This is now present in 1.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants