fix: display only the error message for sql-editor#3174
Open
alecsci wants to merge 5 commits intoazerothcore:masterfrom
Open
fix: display only the error message for sql-editor#3174alecsci wants to merge 5 commits intoazerothcore:masterfrom
alecsci wants to merge 5 commits intoazerothcore:masterfrom
Conversation
alecsci
commented
Nov 20, 2024
Member
Author
alecsci
left a comment
There was a problem hiding this comment.
For the users this is better, for the devs this is worse because we lose the stack-trace, so maybe we should have at the end of the alert message a field for the stack-trace ?
Contributor
|
I would say the "stack" error makes more sense if you're in developer/debug mode |
Member
Author
|
Not sure if it's worth doing that much implementation to hide some technical info. We could show both information, but put first the error message, and then the last field can be the stack trace. |
Member
|
We could show both but in a separate way, so the user can focus on the error message first and then if it's useful can also read the stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3132