chore: remove unneeded electron-builder flags#3744
Merged
Conversation
Drop the electronFuses block, win.verifyUpdateCodeSignature, and win.signAndEditExecutable added in #3740. None of them are required for the ssh2 tunnel to work: - ssh2's native bindings (sshcrypto.node, cpufeatures.node) are auto-unpacked by Electron and don't conflict with default fuses. - onlyLoadAppFromAsar only governs the entry point (main.js), which stays inside the asar. - Embedded asar integrity validation is handled correctly by modern electron-builder, including for asarUnpack entries. - verifyUpdateCodeSignature only matters when electron-updater is active; Keira3 doesn't ship the auto-updater. - signAndEditExecutable: false skipped not only signing (which electron-builder skips automatically without a cert) but also rcedit, which means the portable .exe shipped without its icon or version metadata. Letting it run by default restores both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the electronFuses block, win.verifyUpdateCodeSignature, and win.signAndEditExecutable added in #3740. None of them are required for the ssh2 tunnel to work: