fix(DB/Item): Include no-disenchant and refund flags to Savage Weapons

[Apathyxia]

Disallows disenchanting of these items as well as makes them refundable for 2 hours after purchasing.

The items have been unavailable on live servers (3.3.5a and classic wotlk). However, these items can be used via modules and custom scripts. They are PvP items so the flags are made to match other PvP items.

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

• AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Please specify which tools were used, if any.

Issues Addressed:

• Closes

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[heyitsbench]

The items have been unavailable on live servers (3.3.5a and classic wotlk). However, these items can be used via modules and custom scripts.

Then IMO this change should be made with those modules/scripts. Without proper sourcing, I don't think unobtainable items should have changes like this on AC.

[Nyeriah]

I would agree but then again we already kind of crossed that bridge when we corrected their stats last time around

[heyitsbench]

The stats change had a source to back it up though, no?

[blinkysc]

It could be a plausible assumption this is the case for these though based on the paradigm that these are pvp items and therefor follow same rules?

[TheSCREWEDSoftware]

If this items were not available in official servers I would say keep it in a module or repo unrelated to the core, and the for the sql we shouldn't be over writing the flags, we should be adding or removing from, as stated in the sql standards .

Flag = Flags | BitMask

[TheSCREWEDSoftware]

Refering to this: https://www.azerothcore.org/wiki/sql-standards

To add to above, didnt read the messages prior, if we already went out the way to change the items stats before, than i cant say i disagree wit hte PR