fix(Scripts/IcecrownCitadel): fix Valithria Dreamwalker portals not spawning correctly#25600
Open
mingzi120 wants to merge 2 commits intoazerothcore:masterfrom
Open
fix(Scripts/IcecrownCitadel): fix Valithria Dreamwalker portals not spawning correctly#25600mingzi120 wants to merge 2 commits intoazerothcore:masterfrom
mingzi120 wants to merge 2 commits intoazerothcore:masterfrom
Conversation
github-actions
Bot
added
Script
Member
|
Use spelldifficulty, that eliminates the need to check for heroic |
Contributor
|
#25516 |
mingzi120
force-pushed
the
fix-valithria-portals-clean
branch
from
7a38c75 to
02e2031
Compare
…pawning correctly
mingzi120
force-pushed
the
fix-valithria-portals-clean
branch
from
02e2031 to
7ca2d43
Compare
mingzi120
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression introduced in PR #23477 where Valithria Dreamwalker fails to spawn portals correctly in all difficulties (10/25/Heroic/Normal).
Root cause:
This fix sets the triggered flag to true to ensure all portals spawn correctly in a single loop, and relies on the core's spelldifficulty_dbc system to handle the spell ID automatically.