fix(Core/SmartAI): Mist escort and follow completion granting Credit#25653
Open
sogladev wants to merge 2 commits intoazerothcore:masterfrom
Open
fix(Core/SmartAI): Mist escort and follow completion granting Credit#25653sogladev wants to merge 2 commits intoazerothcore:masterfrom
sogladev wants to merge 2 commits intoazerothcore:masterfrom
Conversation
github-actions
Bot
added
DB
sogladev
force-pushed
the
fix-smartai-action-follow-credit
branch
from
699fb08 to
a7693c3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes SmartAI follow completion credit handling so escort/follow quests (starting with “Mist”) can complete via the credit configured on SMART_ACTION_FOLLOW, and updates Mist’s SAI to use follow completion credit to reset correctly.
Changes:
- Move follow completion credit-granting logic in
SmartAI::StopFollow()to run before the follow state is cleared. - Update Mist (entry 3568) SmartAI to grant quest credit via follow completion credit (instead of distance checks) and ensure it resets/despawns properly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/server/game/AI/SmartScripts/SmartAI.cpp | Adjusts follow-stop logic so follow completion credit can be granted reliably. |
| data/sql/updates/pending_db_world/rev_1777475353267081450.sql | Refactors Mist’s smart_scripts to use follow credit + follow completion for quest completion/reset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+9
| (3568, 0, 5, 0, 6, 0, 100, 512, 0, 0, 0, 0, 0, 0, 70, 1000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Mist - On Just Died - Respawn Self'), | ||
| (3568, 0, 6, 7, 11, 0, 100, 512, 0, 0, 0, 0, 0, 0, 18, 512, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Mist - On Respawn - Set Flags Immune To NPC\'s'), |
Contributor
|
I tested (3568, 30886, 777400, 777401) |
Nyeriah
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Refactor Mist SmartAI, and use Credit set by the follow action to complete the quest.
The Credit handling broke in a refactor some time ago pre-AC:
TrinityCore/TrinityCore@b0ae5fa
The following SmartAI actions are affected:
action_type = 29 and action_param3 > 02547400So far I just tested Mist
AI-assisted Pull Requests
Important
While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.
Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.