Fix spellclick#8232
Fix spellclick#8232Nyeriah merged 33 commits intoazerothcore:masterfrom IntelligentQuantum:CMSG_SPELLCLICK
Conversation
ghost
removed
|
what's the status of this PR? |
Need someone to test it. |
|
@azerothcore/testers
@IntelligentQuantum this is a small change so if you tested it yourself and are sure it doesn't cause any regression, it can be good to go 👍 |
|
@FrancescoBorzi Everything works fine as far as I tested. |
|
@IntelligentQuantum the codestyle check is failing, please have a look at it |
|
All good! |
|
breaks https://wotlkdb.com/?npc=38248 sister svalna spear click script |
Confirmed |
|
@IntelligentQuantum could you please take a look into this? |
@IntelligentQuantum why no answer? |
|
@FrancescoBorzi Sorry, I do not check notifications much @Nyeriah i will check it. |
This reverts commit faa4035.
9 participants
Changes Proposed:
Issues Addressed:
SOURCE:
Tests Performed:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.