Skip to content

Upgrade communication signaling version to 1.0.0.beta.12#1352

Merged
anjulgarg merged 7 commits intomainfrom
anjulgarg/2706004-upgrade-communication-signaling
Jan 25, 2022
Merged

Upgrade communication signaling version to 1.0.0.beta.12#1352
anjulgarg merged 7 commits intomainfrom
anjulgarg/2706004-upgrade-communication-signaling

Conversation

@anjulgarg
Copy link
Copy Markdown
Member

@anjulgarg anjulgarg commented Jan 24, 2022

What

Upgrading communication-signaling to add metadata to events data

Why

The dependency @azure/communication-signaling needs to be updated to 1.0.0.beta.12 as the one we are using (beta.5) doesn't expose metadata in the event type ChatMessageReceivedEvent.

Also update EventSubscriber in Chat stateful client to capture the metadata information and forward it to the state.

(https://skype.visualstudio.com/SPOOL/_workitems/edit/2706004)

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

@anjulgarg anjulgarg enabled auto-merge (squash) January 24, 2022 21:57
@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

@prprabhu-ms prprabhu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should instead be dropping this dependency entirely. We're depending on a beta package from our stable versioned package, which is not good.

iiuc, all the functionality in @azure/communication-signaling should be available via @azure/communication-chat.

@github-actions
Copy link
Copy Markdown
Contributor

@anjulgarg
Copy link
Copy Markdown
Member Author

anjulgarg commented Jan 25, 2022

We should instead be dropping this dependency entirely. We're depending on a beta package from our stable versioned package, which is not good.

iiuc, all the functionality in @azure/communication-signaling should be available via @azure/communication-chat.

Do you have an immediate solution for this?
Or suggestion for going forward?

Problem is that Event Types are not being exported by communication-chat

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@prprabhu-ms
Copy link
Copy Markdown
Contributor

We should instead be dropping this dependency entirely. We're depending on a beta package from our stable versioned package, which is not good.
iiuc, all the functionality in @azure/communication-signaling should be available via @azure/communication-chat.

Do you have an immediate solution for this? Or suggestion for going forward?

Problem is that Event Types are not being exported by communication-chat

Let's bring this up with the chat team. There is no stable supported way to use Event Types right now in that case.

Copy link
Copy Markdown
Contributor

@prprabhu-ms prprabhu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this package bump because it doesn't actually introduce a beta dep... just keeps one already there :/

@anjulgarg anjulgarg merged commit cf149e8 into main Jan 25, 2022
@anjulgarg anjulgarg deleted the anjulgarg/2706004-upgrade-communication-signaling branch January 25, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants