MeetingComposite: Use a SplitButton to show device selection flyout in CameraButton#1436
Merged
prprabhu-ms merged 11 commits intomainfrom Feb 8, 2022
Merged
MeetingComposite: Use a SplitButton to show device selection flyout in CameraButton#1436prprabhu-ms merged 11 commits intomainfrom
SplitButton to show device selection flyout in CameraButton#1436prprabhu-ms merged 11 commits intomainfrom
Conversation
prprabhu-ms
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
JamesBurnside
approved these changes
Feb 7, 2022
Contributor
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
Contributor
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
Contributor
…re/communication-ui-library into prprabhu/camera-split-button
Contributor
dmceachernmsft
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1392 but for
CameraButton.CameraButton. When set, use aSplitButtonwith a context menu for camera device selection.CameraButtonto return video device informationCameraButtonstory to showcase the new fields.CameraButtoninMeetingComposite.How Tested
Stable build
All new API is introduced conditionally. Stable API is unchanged.