Incorporate CallPane into Call Composite with functional button for beta#2109
Conversation
edwardlee-msft
requested review from
JamesBurnside,
PorterNan,
anjulgarg,
carocao-msft,
dmceachernmsft and
mgamis-msft
as code owners
edwardlee-msft
requested review from
prabhjot-msft and
prprabhu-ms
as code owners
Calling bundle size is increased❗.
|
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
CallWithChat bundle size is increased❗.
|
Chat bundle size is decreased✅.
|
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
dmceachernmsft
left a comment
dmceachernmsft
left a comment
There was a problem hiding this comment.
Add the PSTN-calls comment otherwise looks good!
| isMobile={props.isMobile} | ||
| /> | ||
| ) && ( | ||
| /* @conditional-compile-remove(one-to-n-calling) */ /* @conditional-compile-remove(one-to-n-calling) */ |
There was a problem hiding this comment.
Should one of these tags be for (PSTN-calls)?
* Update e2e tests for PeoplePaneContent in Call Composite
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
edwardlee-msft
deleted the
elee/Update-call-composite-to-include-participant-pane
branch
4 participants
What
Incorporate CallPane into Call Composite with a functional button only in beta. Stable build remains untouched while beta flavour incorporates the changes by replacing the Participant Button.
Beta Flavour:
beta.mov
Stable Flavour:
stable.mov
Why
In order to bring Call Composite and CallWithChat Composite into parity, we are working to bring over the People Pane over into the Call Composite. This is one of the final steps in bringing over the People Pane.
How Tested
Test locally on MacOS chrome browser on desktop and mobile view. Tested on both Beta and Stable flavours.
Process & policy checklist
Is this a breaking change?