Match message thread color in composite to composite background#2126
Merged
Match message thread color in composite to composite background#2126
Conversation
anjulgarg
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Member
|
there's some weirdness happening in those snapshot updates |
dmceachernmsft
approved these changes
Jul 26, 2022
|
|
||
| const messageThreadStyles = Object.assign({}, messageThreadChatCompositeStyles, styles?.messageThread); | ||
| const messageThreadStyles = Object.assign( | ||
| {}, |
Member
There was a problem hiding this comment.
Do we need this empty object here incase everything else is undefined? I haven't seen this way of defining the styles on a component.
Contributor
Contributor
Contributor
Contributor
JamesBurnside
approved these changes
Jul 27, 2022
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Match message thread color in composite to composite background
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/2903659
How Tested
Process & policy checklist
Is this a breaking change?