Fix control bar controls showing as disabled when the button is set to true#2325
Merged
JamesBurnside merged 10 commits intomainfrom Sep 14, 2022
Merged
Conversation
JamesBurnside
requested review from
PorterNan,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft and
mgamis-msft
as code owners
JamesBurnside
requested review from
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
Calling bundle size is decreased✅.
|
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Chat bundle size is increased❗.
|
edwardlee-msft
approved these changes
Sep 9, 2022
dmceachernmsft
approved these changes
Sep 14, 2022
Contributor
JamesBurnside
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
…tps://github.com/Azure/communication-ui-library into jaburnsi/fix-control-bar-button-isdisabled-check
…tps://github.com/Azure/communication-ui-library into jaburnsi/fix-control-bar-button-isdisabled-check
Contributor
JamesBurnside
deleted the
jaburnsi/fix-control-bar-button-isdisabled-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
isDisabledfn logicWhy
How Tested
Locally and snapshots should update once #2324 is completed