[Call Readiness] Unsupported Browser UI by dmceachernmsft · Pull Request #2334 · Azure/communication-ui-library

dmceachernmsft · 2022-09-14T00:26:52Z

What

Introduces new UI to alert the user they are using a unsupported browser.

Why

Allows Contoso to provide a way to inform the user they are using a unsupported browser and direct them to documentation to be provided by Contoso letting the user know which browsers to use.

https://skype.visualstudio.com/SPOOL/_workitems/edit/2980682

How Tested

Validated UI and styles in storybook.

…com/Azure/communication-ui-library into dmceachernmsft/unsupportedBrowserUI

github-actions · 2022-09-14T00:37:11Z

Storybook URL https://60c7ae6891f0e90039d7cd54-fdfxtfqcjr.chromatic.com/

github-actions · 2022-09-14T00:41:58Z

Calling bundle size is increased❗.

Current size: 5070593
Base size: 5069547
Diff size: 1046

github-actions · 2022-09-14T00:42:17Z

Chat bundle size is increased❗.

Current size: 5195298
Base size: 5194252
Diff size: 1046

github-actions · 2022-09-14T00:42:28Z

CallWithChat bundle size is increased❗.

Current size: 5456094
Base size: 5455046
Diff size: 1048

github-actions · 2022-09-14T15:43:39Z

Storybook URL https://60c7ae6891f0e90039d7cd54-zmyjngkzul.chromatic.com/

github-actions · 2022-09-14T20:25:19Z

Storybook URL https://60c7ae6891f0e90039d7cd54-zbrgxebzok.chromatic.com/

github-actions · 2022-09-14T21:35:21Z

Storybook URL https://60c7ae6891f0e90039d7cd54-logzxvjnwi.chromatic.com/

github-actions · 2022-09-14T21:52:13Z

Storybook URL https://60c7ae6891f0e90039d7cd54-hembciezsd.chromatic.com/

github-actions · 2022-09-14T22:58:34Z

Storybook URL https://60c7ae6891f0e90039d7cd54-hflccxofzt.chromatic.com/

github-actions · 2022-09-14T23:12:56Z

Storybook URL https://60c7ae6891f0e90039d7cd54-qblgmgtsci.chromatic.com/

github-actions · 2022-09-15T00:00:22Z

Storybook URL https://60c7ae6891f0e90039d7cd54-dnvmbfiomk.chromatic.com/

into dmceachernmsft/unsupportedBrowserUI

github-actions · 2022-09-15T17:28:12Z

Storybook URL https://60c7ae6891f0e90039d7cd54-pxhpkuherl.chromatic.com/

github-actions · 2022-09-15T22:11:00Z

Storybook URL https://60c7ae6891f0e90039d7cd54-jespuewhrb.chromatic.com/

* create new view for the composite * Add base component and strings * remove button * create new story files * add story book content and build * fix icons * move styles to own file * add CC for unsupported browser * more CC work * Change files * fix linter errors * make component beta * remove console * fix cc error * make supporting types interfaces * build API * fix cc * rebuild api * fix nits

* show/hide menu button * Change files * lint fix' * Update composite automation snapshots * fix test * Update composite automation snapshots * Update composite automation snapshots * show elipses when hovered * Update composite automation snapshots * Update composite automation snapshots * change id to classname' * Update composite automation snapshots * Update composite automation snapshots * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * Update storybook to contain docs on customizing call controls in call composite (#2333) * snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * test * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * [Call Readiness] Unsupported Browser UI (#2334) * create new view for the composite * Add base component and strings * remove button * create new story files * add story book content and build * fix icons * move styles to own file * add CC for unsupported browser * more CC work * Change files * fix linter errors * make component beta * remove console * fix cc error * make supporting types interfaces * build API * fix cc * rebuild api * fix nits * Small Refactor: move call composite side pane state handling to its own hook (#2342) * Add instructions to update callwithchat hero sample (#2337) * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * new changes based on standup discussion * new changes based on standup discussion * new changes based on standup discussion * test fix * test fix * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * delete old snapshot' * Update packages/react-composites CallComposite browser test snapshots * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Anjul Garg <anjulgarg@live.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com>

* create new view for the composite * Add base component and strings * remove button * create new story files * add story book content and build * fix icons * move styles to own file * add CC for unsupported browser * more CC work * Change files * fix linter errors * make component beta * remove console * fix cc error * make supporting types interfaces * build API * fix cc * rebuild api * fix nits

* show/hide menu button * Change files * lint fix' * Update composite automation snapshots * fix test * Update composite automation snapshots * Update composite automation snapshots * show elipses when hovered * Update composite automation snapshots * Update composite automation snapshots * change id to classname' * Update composite automation snapshots * Update composite automation snapshots * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * Update storybook to contain docs on customizing call controls in call composite (#2333) * snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * test * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * [Call Readiness] Unsupported Browser UI (#2334) * create new view for the composite * Add base component and strings * remove button * create new story files * add story book content and build * fix icons * move styles to own file * add CC for unsupported browser * more CC work * Change files * fix linter errors * make component beta * remove console * fix cc error * make supporting types interfaces * build API * fix cc * rebuild api * fix nits * Small Refactor: move call composite side pane state handling to its own hook (#2342) * Add instructions to update callwithchat hero sample (#2337) * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * new changes based on standup discussion * new changes based on standup discussion * new changes based on standup discussion * test fix * test fix * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * delete old snapshot' * Update packages/react-composites CallComposite browser test snapshots * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Anjul Garg <anjulgarg@live.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com>

* error bar * Change files * error bar * error bar * use action * use action * use action * pr change * [Call Readiness] Unsupported Browser UI (#2334) * create new view for the composite * Add base component and strings * remove button * create new story files * add story book content and build * fix icons * move styles to own file * add CC for unsupported browser * more CC work * Change files * fix linter errors * make component beta * remove console * fix cc error * make supporting types interfaces * build API * fix cc * rebuild api * fix nits * Small Refactor: move call composite side pane state handling to its own hook (#2342) * Add instructions to update callwithchat hero sample (#2337) * Show/hide menu button on hover/click/focus (#2319) * show/hide menu button * Change files * lint fix' * Update composite automation snapshots * fix test * Update composite automation snapshots * Update composite automation snapshots * show elipses when hovered * Update composite automation snapshots * Update composite automation snapshots * change id to classname' * Update composite automation snapshots * Update composite automation snapshots * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * Update storybook to contain docs on customizing call controls in call composite (#2333) * snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * test * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * [Call Readiness] Unsupported Browser UI (#2334) * create new view for the composite * Add base component and strings * remove button * create new story files * add story book content and build * fix icons * move styles to own file * add CC for unsupported browser * more CC work * Change files * fix linter errors * make component beta * remove console * fix cc error * make supporting types interfaces * build API * fix cc * rebuild api * fix nits * Small Refactor: move call composite side pane state handling to its own hook (#2342) * Add instructions to update callwithchat hero sample (#2337) * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * new changes based on standup discussion * new changes based on standup discussion * new changes based on standup discussion * test fix * test fix * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * delete old snapshot' * Update packages/react-composites CallComposite browser test snapshots * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Anjul Garg <anjulgarg@live.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> * error bar * error bar * build file * Revert "error bar" This reverts commit cc0c577. * fix index Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Anjul Garg <anjulgarg@live.com>

dmceachernmsft added 6 commits September 13, 2022 00:07

create new view for the composite

8d65741

Add base component and strings

62b14b7

remove button

128a0ea

create new story files

637b487

add story book content and build

20a53b9

fix icons

776332c

dmceachernmsft assigned JamesBurnside Sep 14, 2022

dmceachernmsft requested a review from alkwa-msft as a code owner September 14, 2022 00:26

dmceachernmsft assigned carocao-msft Sep 14, 2022

dmceachernmsft requested review from JamesBurnside, anjulgarg, carocao-msft, edwardlee-msft and mgamis-msft as code owners September 14, 2022 00:26

dmceachernmsft assigned edwardlee-msft Sep 14, 2022

dmceachernmsft requested review from PorterNan, prabhjot-msft and prprabhu-ms as code owners September 14, 2022 00:26

dmceachernmsft added 3 commits September 13, 2022 17:26

Merge branch 'main' into dmceachernmsft/unsupportedBrowserUI

0c639f5

move styles to own file

62275b3

Merge branch 'dmceachernmsft/unsupportedBrowserUI' of https://github.…

5fee8e3

…com/Azure/communication-ui-library into dmceachernmsft/unsupportedBrowserUI

JamesBurnside approved these changes Sep 14, 2022

View reviewed changes

Merge branch 'main' into dmceachernmsft/unsupportedBrowserUI

f4031f9

dmceachernmsft added 2 commits September 14, 2022 15:48

add CC for unsupported browser

4eb1fa0

more CC work

9d65d96

Merge branch 'main' into dmceachernmsft/unsupportedBrowserUI

e344c64

JamesBurnside reviewed Sep 14, 2022

View reviewed changes

Comment thread packages/react-components/src/localization/LocalizationProvider.tsx Outdated

make component beta

81ecd76

remove console

7084c58

dmceachernmsft added 2 commits September 14, 2022 22:50

fix cc error

26f9460

make supporting types interfaces

061a4a2

dmceachernmsft added 2 commits September 14, 2022 22:59

build API

3a161f3

Merge branch 'main' into dmceachernmsft/unsupportedBrowserUI

26d9c62

fix cc

9478170

dmceachernmsft added 2 commits September 15, 2022 17:11

Merge branch 'main' of https://github.com/Azure/communication-ui-library

4aea0e0

into dmceachernmsft/unsupportedBrowserUI

rebuild api

8a0b829

edwardlee-msft reviewed Sep 15, 2022

View reviewed changes

Comment thread packages/react-components/src/components/UnsupportedBrowser.tsx Outdated

edwardlee-msft reviewed Sep 15, 2022

View reviewed changes

Comment thread packages/react-components/src/components/UnsupportedBrowser.tsx Outdated

fix nits

de34437

edwardlee-msft approved these changes Sep 15, 2022

View reviewed changes

dmceachernmsft merged commit 5fdeb47 into main Sep 15, 2022

dmceachernmsft deleted the dmceachernmsft/unsupportedBrowserUI branch September 15, 2022 22:36

Conversation

dmceachernmsft commented Sep 14, 2022

What

Why

How Tested

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

github-actions Bot commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Calling bundle size is increased❗.

Uh oh!

github-actions Bot commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chat bundle size is increased❗.

Uh oh!

github-actions Bot commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CallWithChat bundle size is increased❗.

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

github-actions Bot commented Sep 15, 2022

Uh oh!

github-actions Bot commented Sep 15, 2022

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Sep 14, 2022 •

edited

Loading

github-actions Bot commented Sep 14, 2022 •

edited

Loading

github-actions Bot commented Sep 14, 2022 •

edited

Loading