Tooltip strings uncapitilized#2350
Merged
mgamis-msft merged 4 commits intomainfrom Sep 21, 2022
Merged
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
edwardlee-msft
approved these changes
Sep 19, 2022
dmceachernmsft
approved these changes
Sep 20, 2022
| "tooltipVideoLoadingContent": "Video is loading", | ||
| "cameraMenuTitle": "Camera", | ||
| "cameraMenuTooltip": "Choose Camera", | ||
| "cameraMenuTooltip": "Choose camera", |
Member
There was a problem hiding this comment.
Is this something that also needs to be done in the composite strings as well?
Contributor
Author
There was a problem hiding this comment.
Yes. But I did not find any tooltip strings in the composite. So I think we are good :)
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updated en-US tool tip strings to be capitalize only the first word.
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/2961689
How Tested
Locally
https://user-images.githubusercontent.com/79475487/190564926-32f47efd-3cc0-44fb-b28f-f7d7cac5042f.mp4
Process & policy checklist
Is this a breaking change?