Update domain permissions to support individual camera and microphone modals#2485
Merged
JamesBurnside merged 13 commits intomainfrom Nov 4, 2022
Merged
Update domain permissions to support individual camera and microphone modals#2485JamesBurnside merged 13 commits intomainfrom
JamesBurnside merged 13 commits intomainfrom
Conversation
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
JamesBurnside
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
JamesBurnside
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
JamesBurnside
commented
Nov 4, 2022
| const theme = useTheme(); | ||
| return ( | ||
| <Stack style={{ padding: '2rem', maxWidth: '25.375rem' }} aria-label={strings?.ariaLabel}> | ||
| <Stack horizontal style={{ paddingBottom: '1rem' }} horizontalAlign={'space-between'}> |
Member
Author
There was a problem hiding this comment.
nit: this should have props.cameraIconName || props.connectorIconName || props.microphoneIconName
carocao-msft
approved these changes
Nov 4, 2022
edwardlee-msft
approved these changes
Nov 4, 2022
Base automatically changed from
jaburnsi/move-device-permissions-components-into-folder
to
main
November 4, 2022 17:19
Contributor
JamesBurnside
force-pushed
the
jaburnsi/domainPermissionsUIUpdates
branch
from
a33e804 to
5c4f9b9
Compare
JamesBurnside
force-pushed
the
jaburnsi/domainPermissionsUIUpdates
branch
from
5c4f9b9 to
18f6929
Compare
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
New call readiness designs
How Tested
Just in storybook, the prompt logic is changing and will be a separate PR
Before:
After: