Update small packages #2527
Merged
dmceachernmsft merged 18 commits intomainfrom Nov 16, 2022
Merged
Conversation
dmceachernmsft
added
the
update_snapshots
dmceachernmsft
requested review from
JamesBurnside,
anjulgarg,
carocao-msft,
edwardlee-msft and
mgamis-msft
as code owners
dmceachernmsft
requested review from
PorterNan,
prabhjot-msft and
prprabhu-ms
as code owners
github-actions
Bot
removed
the
update_snapshots
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
Calling bundle size is increased❗.
|
…ure/communication-ui-library into dmceachernmsft/updatePackages
…ure/communication-ui-library into dmceachernmsft/updatePackages
Contributor
Member
|
These look like they've moved too far apart: |
Member
|
Unassigning myself for load balancing |
prprabhu-ms
reviewed
Nov 15, 2022
Contributor
prprabhu-ms
left a comment
prprabhu-ms
left a comment
There was a problem hiding this comment.
SendBox with files now has more space under the text than earlier / figma. Worth looking at why.
prprabhu-ms
reviewed
Nov 15, 2022
Contributor
prprabhu-ms
left a comment
prprabhu-ms
left a comment
There was a problem hiding this comment.
The two pointed out so far are worth looking at. The other two:
- Dialpad numbers/text have extra padding between them
- FileSharing error bar has an extra pixel or 2 height
are OK. They bring the components in alignment with the figma.
dmceachernmsft
added
the
update_snapshots
Contributor
JamesBurnside
approved these changes
Nov 16, 2022
prprabhu-ms
reviewed
Nov 16, 2022
prprabhu-ms
reviewed
Nov 16, 2022
| <Stack | ||
| styles={iconBannerContainerStyles} | ||
| horizontal | ||
| horizontalAlign={'center'} |
Contributor
There was a problem hiding this comment.
This can just be horizontalAlign="center"
https://reactjs.org/docs/introducing-jsx.html#specifying-attributes-with-jsx
github-actions
Bot
removed
the
update_snapshots
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
…ure/communication-ui-library into dmceachernmsft/updatePackages
Contributor
prprabhu-ms
approved these changes
Nov 16, 2022
Contributor
edwardlee-msft
pushed a commit
that referenced
this pull request
Nov 17, 2022
edwardlee-msft
added a commit
that referenced
this pull request
Nov 17, 2022
…2475) (#2535) * Cherry-pick Update calling SDK for unsupportedBrowser (1.9.1-beta.1) (#2475) * Cherrypick Update small packages #2527 * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites ChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the lockfile for any new versions of our dependencies
Why
Allows us to update the UI snapshots per these smaller updates
How Tested
Update snapshots