You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.
This is an interesting scenario and not sure if I agree. I can see how this would make sense for a call that is already dialling, but for a call that has yet to be dialled I can see a need to edit the middle of the number.
But regardless, I can see that Alex P provided his input so no issues either.
This is an interesting scenario and not sure if I agree. I can see how this would make sense for a call that is already dialling, but for a call that has yet to be dialled I can see a need to edit the middle of the number.
But regardless, I can see that Alex P provided his input so no issues either.
To edit the middle of number you can click and then using the left arrow on keyboard to move cursor to the middle. I was concerned about this as well so I made sure we can still do that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carocao-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
dmceachernmsft,
edwardlee-msft and
mgamis-msft
as code owners
What
Cursor should show at the end when clicking in dialpad textfield
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3015832
How Tested
dialpad.mov
Process & policy checklist
Is this a breaking change?