Fix VideoTile menu button to show on hover when isSpeaking is true#2721
Merged
mgamis-msft merged 6 commits intomainfrom Feb 14, 2023
Merged
Fix VideoTile menu button to show on hover when isSpeaking is true#2721mgamis-msft merged 6 commits intomainfrom
mgamis-msft merged 6 commits intomainfrom
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft and
prabhjot-msft
as code owners
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
edwardlee-msft
approved these changes
Feb 8, 2023
Contributor
Contributor
Contributor
dmceachernmsft
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove zIndex from VideoTIle and its isSpeaking border. Reordered LayerHost in FloatingLocalVideoLayout to be before the VideoTiles.
Why
Bug from bug bash where VideoTile does not show menu button on hover when isSpeaking is true.
https://user-images.githubusercontent.com/79475487/217512366-5b7d315b-7546-483d-b745-200dd0f4f327.mp4
How Tested
Tested VideoTile:
https://user-images.githubusercontent.com/79475487/217512554-13a141fc-d8b3-4107-a3b8-e4b4e340297e.mp4
Tested VideoGallery floating local video is still draggable:
https://user-images.githubusercontent.com/79475487/217512595-51916059-4d05-48ae-96d3-1812f27afc08.mp4
Process & policy checklist
Is this a breaking change?