Fix: Add support for overflow button in desktop callwithchat#2748
Merged
JamesBurnside merged 4 commits intomainfrom Feb 13, 2023
Merged
Conversation
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
Contributor
Calling bundle size is decreased✅.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
CallWithChat bundle size is increased❗.
|
edwardlee-msft
approved these changes
Feb 13, 2023
dmceachernmsft
approved these changes
Feb 13, 2023
JamesBurnside
deleted the
jaburnsi/fix-custom-overflow-button-callwithchat-desktop
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DesktopMoreButtonto take in custom buttons from composite > options > custom buttonsWhy
How Tested
Ran locally:
