Fix side pane when composite is narrow#2864
Merged
mgamis-msft merged 27 commits intomainfrom Mar 31, 2023
Merged
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft and
prabhjot-msft
as code owners
mgamis-msft
requested review from
a team,
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
lpeixin,
palatter,
vhuseinova-msft and
waynemo
dmceachernmsft
approved these changes
Mar 31, 2023
| // Copyright (c) Microsoft Corporation. | ||
|
|
||
| /** | ||
| * @private |
Member
There was a problem hiding this comment.
nit: Maybe add a small comment here as to what the number is for.
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
…://github.com/Azure/communication-ui-library into mgamis/fix-side-pane-when-composite-is-narrow
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
mgamis-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
mgamis-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
…://github.com/Azure/communication-ui-library into mgamis/fix-side-pane-when-composite-is-narrow
…://github.com/Azure/communication-ui-library into mgamis/fix-side-pane-when-composite-is-narrow
…://github.com/Azure/communication-ui-library into mgamis/fix-side-pane-when-composite-is-narrow
prabhjot-msft
approved these changes
Mar 31, 2023
Contributor
Contributor
mgamis-msft
added a commit
that referenced
this pull request
Mar 31, 2023
* set min width of composite content to 30rem * Change files * Duplicate change files for beta release * fix incorrect file header * Add comment to variable and simplified variable name * include minWidth styling for stable * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * apply minwidth only when not mobile * cond-comp import * cond-comp fix * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * revert all snapshot updates --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
mgamis-msft
added a commit
that referenced
this pull request
Apr 1, 2023
* Fix side pane when composite is narrow (#2864) * set min width of composite content to 30rem * Change files * Duplicate change files for beta release * fix incorrect file header * Add comment to variable and simplified variable name * include minWidth styling for stable * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * apply minwidth only when not mobile * cond-comp import * cond-comp fix * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * revert all snapshot updates --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * update beta release notes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set composite min width to 30rem to avoid overlap of side pane when it is open.
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3207599
How Tested
Local sample testing
Process & policy checklist
Is this a breaking change?