[Beta-blocking] Fix speaker icon in contextual menu of microphone and devices button#3294
Merged
mgamis-msft merged 5 commits intomainfrom Jun 29, 2023
Merged
Conversation
mgamis-msft
requested review from
carocao-msft,
dmceachernmsft and
edwardlee-msft
mgamis-msft
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
mgamis-msft
changed the title
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
|
Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
JamesBurnside
approved these changes
Jun 29, 2023
Contributor
Leah-Xia-Microsoft
pushed a commit
that referenced
this pull request
Jun 29, 2023
… devices button (#3294) * Fix speaker icon in contextual menu of microphone and devices button * Change files * Duplicate change log for beta * api changes * stable api changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add speaker icon for contextual menu of microphone and devices button
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3323978
How Tested
Local call with chat sample testing
before:
https://github.com/Azure/communication-ui-library/assets/79475487/eced8e7c-82b7-4e4b-8b67-df5db6705b22
after:
https://github.com/Azure/communication-ui-library/assets/79475487/6b91fa07-3dc8-4003-aeb4-b5c7941b44f8
Process & policy checklist
Is this a breaking change?