[Chat] Fix mention popover content view is not wrapped up in the scroll view when the list is long#3339
Merged
Leah-Xia-Microsoft merged 4 commits intomainfrom Jul 13, 2023
Conversation
Leah-Xia-Microsoft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is increased❗.
|
emlynmac
approved these changes
Jul 13, 2023
vhuseinova-msft
approved these changes
Jul 13, 2023
…t-of-the-scroll-view
Contributor
Leah-Xia-Microsoft
deleted the
leahxia/fix-mention-popover-content-float-out-of-the-scroll-view
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Before:
After:
How Tested
Process & policy checklist
Is this a breaking change?