Update captions banner width and height to increase readability#3359
Merged
carocao-msft merged 10 commits intomainfrom Jul 24, 2023
Merged
Update captions banner width and height to increase readability#3359carocao-msft merged 10 commits intomainfrom
carocao-msft merged 10 commits intomainfrom
Conversation
carocao-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
…nication-ui-library into carocao/captionsSize
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "prerelease", | |||
Member
There was a problem hiding this comment.
If this is for Captions GA is this pre-release?
Contributor
Author
There was a problem hiding this comment.
It's feature related changes, I think it should be prerelease?
| export const loadingBannerClassName = mergeStyles({ | ||
| height: _pxToRem(100) | ||
| }); | ||
| export const loadingBannerClassName = (formFactor: 'default' | 'compact'): IStackStyles => { |
Member
There was a problem hiding this comment.
Can we change the naming for these styles? I don't agree that they are a classname, we should be calling this loadingBannerStyles there are a lot of other classes like this.
Contributor
There was a problem hiding this comment.
I agree with this as well.
edwardlee-msft
approved these changes
Jul 22, 2023
Contributor
dmceachernmsft
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update captions banner width and height to increase readability
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3245322
https://skype.visualstudio.com/SPOOL/_workitems/edit/3245318
How Tested
Tested with samples
Process & policy checklist
Is this a breaking change?