[bugfix][a11y] video effects item add default aria labels#3477
Merged
edwardlee-msft merged 4 commits intomainfrom Aug 18, 2023
Merged
[bugfix][a11y] video effects item add default aria labels#3477edwardlee-msft merged 4 commits intomainfrom
edwardlee-msft merged 4 commits intomainfrom
Conversation
edwardlee-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
dmceachernmsft
approved these changes
Aug 18, 2023
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
JamesBurnside
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add default aria labels for video effect items as per accessibility requirement. Using item key if no aria-label is provided.
Why
Videoeffectitems do not have an aria label if not passed down as a prop.
To prevent no aria-label present, default aria-labels are set if an aria-label is not passed down.
https://skype.visualstudio.com/SPOOL/_workitems/edit/3326846
How Tested
MacOS calling sample voiceover