[Stable blocking] Prevent showing screenShareButton when formFactor is set to mobile#3915
Conversation
mgamis-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
mgamis-msft
changed the title
Calling bundle size is increased❗.
|
| callControls: { | ||
| screenShareButton: !shouldDisableScreenShare | ||
| } | ||
| callControls: shouldDisableScreenShare |
There was a problem hiding this comment.
Avoid setting the whole callControls object based on shouldDisableScreenShare, makes it hard for someone to add options to this in future (they'd have to move the shouldDisableScreenShare)
Instead can we do:
callControls: {
screenShareButton: shouldDisableScreenShare ? false : undefined
}
?
There was a problem hiding this comment.
(Or fix the shouldDisableScreenshare to be isMobile || isIOS instead of just isIOS)
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
mgamis-msft
deleted the
mgamis/revise-bug-fix-to-hide-screenshare-button-for-iOS
branch
3 participants
What
Prevent showing screenShareButton when formFactor is set to mobile
Why
CallControlOptions
screenShareButtonwas set to true by accident on sample app for all devices that are not iOS. We should prevent showing the screenShareButton when formFactor is set to mobileHow Tested
Local testing of Calling and CallwithChat samples on Desktop and Android
Process & policy checklist
Is this a breaking change?