Fix side pane content being clipped on a small screen at 200% zoom#3937
Merged
JamesBurnside merged 8 commits intomainfrom Dec 23, 2023
Merged
Fix side pane content being clipped on a small screen at 200% zoom#3937JamesBurnside merged 8 commits intomainfrom
JamesBurnside merged 8 commits intomainfrom
Conversation
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
JamesBurnside
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
edwardlee-msft
approved these changes
Dec 22, 2023
Contributor
carocao-msft
approved these changes
Dec 23, 2023
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set appropriate minWidths and pull out and document constants
Why
At 200+% zoom and 1024x768 resolution, the side panes were super small and incredibly difficult to interact with
How Tested
Local testing at 200+% zoom levels at a 1024x768 resolution