[Chat] Fix for a race condition for "The message is deleted" announcement#3946
Merged
vhuseinova-msft merged 5 commits intomainfrom Dec 22, 2023
Merged
Conversation
vhuseinova-msft
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft and
waynemo
…sage-announcement-fix
Leah-Xia-Microsoft
approved these changes
Dec 22, 2023
Contributor
jimchou-dev
approved these changes
Dec 22, 2023
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
palatter
approved these changes
Dec 22, 2023
vhuseinova-msft
deleted the
vhuseinova/delete-message-announcement-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A race condition for lastDeletedMessageId was found in 1 of the partners app, this PR will fix it.
Why
How Tested
Checked with the partner team that solution works for them. Tested with sample that it didn't break things for us.
Process & policy checklist
Is this a breaking change?