Skip to content

[bugfix] Custom data model onFetchAvatarPersonaData fix in PeoplePane for stable#4391

Merged
edwardlee-msft merged 5 commits intomainfrom
elee/custom-data-model-fix-for-stable
Apr 2, 2024
Merged

[bugfix] Custom data model onFetchAvatarPersonaData fix in PeoplePane for stable#4391
edwardlee-msft merged 5 commits intomainfrom
elee/custom-data-model-fix-for-stable

Conversation

@edwardlee-msft
Copy link
Copy Markdown
Contributor

What

Remove unused cc code that was blocking people pane from receiving onFetchAvatarPersonaData in stable

Why

People pane avatars were not being updated despite gallery being updated.

How Tested

MacOS Chrome Calling sample

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2024

Chat bundle size is not changed.

  • Current size: 2105219
  • Base size: 2105219
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2024

CallWithChat bundle size is not changed.

  • Current size: 6184129
  • Base size: 6184129
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2024

Calling bundle size is not changed.

  • Current size: 4806120
  • Base size: 4806120
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49439 / 79104
62.49%
49439 / 79104
62.49%
1009 / 2257
44.7%
2831 / 4661
60.73%
Current 49410 / 79101
62.46%
49410 / 79101
62.46%
1009 / 2257
44.7%
2838 / 4667
60.8%
Diff -29 / -3
-0.03%
-29 / -3
-0.03%
0 / 0
0%
7 / 6
0.07%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 23686 / 36519
64.85%
23686 / 36519
64.85%
659 / 1149
57.35%
1899 / 3018
62.92%
Current 23629 / 36519
64.7%
23629 / 36519
64.7%
659 / 1149
57.35%
1904 / 3014
63.17%
Diff -57 / 0
-0.15%
-57 / 0
-0.15%
0 / 0
0%
5 / -4
0.25%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2024

@edwardlee-msft edwardlee-msft merged commit bf09ec2 into main Apr 2, 2024
@edwardlee-msft edwardlee-msft deleted the elee/custom-data-model-fix-for-stable branch April 2, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants