Skip to content

Fix bug where there are duplicate captions #4534

Merged
carocao-msft merged 2 commits intomainfrom
carocao/bug
Apr 25, 2024
Merged

Fix bug where there are duplicate captions #4534
carocao-msft merged 2 commits intomainfrom
carocao/bug

Conversation

@carocao-msft
Copy link
Copy Markdown
Contributor

What

Fix bug where there are duplicate captions

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

Calling bundle size is increased❗.

  • Current size: 4879571
  • Base size: 4879569
  • Diff size: 2

@github-actions
Copy link
Copy Markdown
Contributor

Chat bundle size is not changed.

  • Current size: 2149408
  • Base size: 2149408
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

CallWithChat bundle size is increased❗.

  • Current size: 6273628
  • Base size: 6273626
  • Diff size: 2

@github-actions
Copy link
Copy Markdown
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25332 / 39228
64.57%
25332 / 39228
64.57%
697 / 1229
56.71%
2030 / 3199
63.45%
Current 25278 / 39228
64.43%
25278 / 39228
64.43%
697 / 1229
56.71%
1991 / 3185
62.51%
Diff -54 / 0
-0.14%
-54 / 0
-0.14%
0 / 0
0%
-39 / -14
-0.94%

@github-actions
Copy link
Copy Markdown
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49702 / 79208
62.74%
49702 / 79208
62.74%
1034 / 2298
44.99%
2897 / 4764
60.81%
Current 49701 / 79208
62.74%
49701 / 79208
62.74%
1034 / 2298
44.99%
2899 / 4764
60.85%
Diff -1 / 0
0%
-1 / 0
0%
0 / 0
0%
2 / 0
0.04%

@carocao-msft carocao-msft merged commit 02420bf into main Apr 25, 2024
@carocao-msft carocao-msft deleted the carocao/bug branch April 25, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants