Conversation
emlynmac
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
vhuseinova-msft
approved these changes
May 29, 2024
Contributor
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
emlynmac
commented
May 29, 2024
| */ | ||
| defaultOnRender?: (props: CustomAvatarOptions) => JSX.Element | ||
| ) => JSX.Element; | ||
| ) => JSX.Element | undefined; |
Member
Author
There was a problem hiding this comment.
Note, this is not a breaking change as it is now less restrictive and existing code will function fine.
Contributor
JamesBurnside
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MessageThread'sonRenderAvatarmethod is used to provide an override of the default Icon for a message.This change enables the callback to return
undefinedwhich will cause the avatar to be hidden.Why
More flexibility to use the component.
How Tested
Sample Chat App
Process & policy checklist
Is this a breaking change?