[Chat] Fixed the issue where RTE doesn't send HTML messages if there are attached files#4747
Merged
[Chat] Fixed the issue where RTE doesn't send HTML messages if there are attached files#4747
Conversation
jpeng-ms
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
emlynmac,
jimchou-dev,
palatter,
vhuseinova-msft and
waynemo
jpeng-ms
assigned
palatter,
vhuseinova-msft,
Leah-Xia-Microsoft,
jimchou-dev and
emlynmac
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is increased❗.
|
emlynmac
approved these changes
Jun 18, 2024
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
| "type": "patch", | ||
| "area": "fix", | ||
| "workstream": "File Sharing", | ||
| "comment": "Fixed the issue where RTE cannot send rich text with file attachments", |
Member
There was a problem hiding this comment.
could you please use rich text editor instead of RTE?
vhuseinova-msft
approved these changes
Jun 18, 2024
Member
vhuseinova-msft
left a comment
vhuseinova-msft
left a comment
There was a problem hiding this comment.
Minor comment but otherwise looks good!
vhuseinova-msft
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
when sending messages with attachments via RTE, raw HTML would be sending out and this PR address this issue:
Why
bug fix
How Tested
sample app
enable RTE
send a message with any attachments
Process & policy checklist
Is this a breaking change?