Fix error when listening to spotlight and capabilities events for call with chat adapter#5066
Merged
mgamis-msft merged 5 commits intomainfrom Aug 24, 2024
Conversation
…vents for AzureCommunicationCallWithChatAdapter
mgamis-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-siaqarcqeg.chromatic.com/ |
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-srerhgbbpc.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
carocao-msft
approved these changes
Aug 23, 2024
prabhjot-msft
approved these changes
Aug 23, 2024
…-for-call-with-chat-adapter
Contributor
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-ebbqqodwyi.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dbrrheshei.chromatic.com/ |
mgamis-msft
deleted the
mgamis/fix-spotlight-and-capabilities-events-for-call-with-chat-adapter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix error when listening to spotlight and capabilities events for call with chat adapter
Why
The following error shows when you subscribe to 'spotlightChanged' event of the AzureCommunicationCallWithChatAdapter
Similar error is shown for 'capabilitiesChanged' event
How Tested
Verified listening to 'spotlightChanged' and 'capabilitiesChanged' in local CallWithChat works in this video:
https://github.com/user-attachments/assets/c6d7984f-9435-4c74-8df3-7d5015ab57c8
Process & policy checklist
Is this a breaking change?