Skip to content

Fix wifi warning icon size in error bar#5282

Merged
mgamis-msft merged 7 commits intomainfrom
mgamis/fix-wifi-warning-icon-size
Dec 12, 2024
Merged

Fix wifi warning icon size in error bar#5282
mgamis-msft merged 7 commits intomainfrom
mgamis/fix-wifi-warning-icon-size

Conversation

@mgamis-msft
Copy link
Copy Markdown
Contributor

What

Fix wifi warning icon size in error bar so that error bars messages are aligned

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3815330

How Tested

Tested in local storybook8 to compare with other error bar icons
image
image

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 2, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 2, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 55497 / 90662
61.21%
55497 / 90662
61.21%
1149 / 2601
44.17%
3388 / 5561
60.92%
Current 55480 / 90659
61.19%
55480 / 90659
61.19%
1149 / 2601
44.17%
3421 / 5584
61.26%
Diff -17 / -3
-0.02%
-17 / -3
-0.02%
0 / 0
0%
33 / 23
0.34%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 2, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 2, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 2, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27497 / 43542
63.15%
27497 / 43542
63.15%
771 / 1372
56.19%
2318 / 3637
63.73%
Current 27494 / 43540
63.14%
27494 / 43540
63.14%
771 / 1372
56.19%
2291 / 3622
63.25%
Diff -3 / -2
-0.01%
-3 / -2
-0.01%
0 / 0
0%
-27 / -15
-0.48%

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@mgamis-msft mgamis-msft added the update_snapshots Set this label to request automated update of UI snapshots label Dec 12, 2024
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Dec 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

Chat bundle size is decreased✅.

  • Current size: 1765302
  • Base size: 1765341
  • Diff size: -39

@github-actions
Copy link
Copy Markdown
Contributor

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

@mgamis-msft mgamis-msft merged commit 8e57446 into main Dec 12, 2024
@mgamis-msft mgamis-msft deleted the mgamis/fix-wifi-warning-icon-size branch December 12, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants