Fix move/close menu not showing on draggable video tile when ctrl+alt+space shortcut is used#5652
Merged
JamesBurnside merged 3 commits intomainfrom Feb 19, 2025
Merged
Conversation
… ctrl+alt+space shortcut is used
JamesBurnside
requested review from
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-eesirpoxhj.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- change-beta/@azure-communication-react-efaa1c36-cd40-48ac-8905-e7c88a135523.json: Language not supported
- change/@azure-communication-react-efaa1c36-cd40-48ac-8905-e7c88a135523.json: Language not supported
Comments suppressed due to low confidence (2)
packages/react-components/src/components/ModalClone/ModalClone.tsx:93
- Changing the event type from React.KeyboardEvent to KeyboardEvent might cause type mismatches or runtime errors if the function is called with a React.KeyboardEvent. Ensure all call sites are updated accordingly.
const getMoveDelta = (ev: KeyboardEvent): number => {
packages/react-components/src/components/ModalClone/ModalClone.tsx:154
- Using window as the default value for keyEventElement might lead to unexpected behavior in environments where window is not available, such as server-side rendering. Ensure window is always available or provide a fallback mechanism.
keyEventElement = window
edwardlee-msft
approved these changes
Feb 18, 2025
dmceachernmsft
approved these changes
Feb 19, 2025
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rkcfryznbq.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
forceUpdateCallbackthat triggers a rerender to remove themoveicon, the icon wasn't being removed in react18 due to the render optimizations; there is no set state triggering a re-render and no longer an unrelated re-render occurringkeyEventElementso window doesn't have to be used (not being used by component or composite currently as it would be a larger change with an API change, no regression in continuing to use window object for now)Why
React 18 strict mode broke the a11y menu for the draggable tile, see recording below for menu being fixed
How Tested
move-keyboard-recording.mp4