Skip to content

Update Changelog to include changes for storybook#5731

Merged
carocao-msft merged 6 commits intomainfrom
carocao/StorybookChangelog
Mar 28, 2025
Merged

Update Changelog to include changes for storybook#5731
carocao-msft merged 6 commits intomainfrom
carocao/StorybookChangelog

Conversation

@carocao-msft
Copy link
Copy Markdown
Contributor

@carocao-msft carocao-msft commented Mar 24, 2025

What

To make storybook testing easier, we are including storybook as part of the changelog system.
If you have make storybook changes, select Minor -> Storybook and log down the changes made.
Release driver can look at the changelogs and determine which storybook page needs to be tested.

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 24, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28095 / 44726
62.81%
28095 / 44726
62.81%
788 / 1439
54.76%
2334 / 3712
62.87%
Current 28098 / 44726
62.82%
28098 / 44726
62.82%
788 / 1439
54.76%
2355 / 3731
63.11%
Diff 3 / 0
0.01%
3 / 0
0.01%
0 / 0
0%
21 / 19
0.24%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 24, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58436 / 94478
61.85%
58436 / 94478
61.85%
1180 / 2698
43.73%
3533 / 5836
60.53%
Current 58457 / 94478
61.87%
58457 / 94478
61.87%
1180 / 2698
43.73%
3536 / 5838
60.56%
Diff 21 / 0
0.02%
21 / 0
0.02%
0 / 0
0%
3 / 2
0.03%

disallowedChangeTypes: [
"major",
"none"
"major"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we continue using patch/minor for this instead of adding none back (as the changes will be added to the changelog file)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@@ -0,0 +1,9 @@
{
"type": "none",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated too? (as we don't support none type anymore)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@github-actions
Copy link
Copy Markdown
Contributor

Chat bundle size is not changed.

  • Current size: 1775237
  • Base size: 1775237
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

Calling bundle size is not changed.

  • Current size: 12401036
  • Base size: 12401036
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401048
  • Base size: 12401048
  • Diff size: 0

@carocao-msft carocao-msft merged commit 3efdc5e into main Mar 28, 2025
40 checks passed
@carocao-msft carocao-msft deleted the carocao/StorybookChangelog branch March 28, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants