[Accessibility Bug Fix] RTT Modal heading is not defined as heading#5800
Merged
carocao-msft merged 4 commits intomainfrom Apr 29, 2025
Merged
[Accessibility Bug Fix] RTT Modal heading is not defined as heading#5800carocao-msft merged 4 commits intomainfrom
carocao-msft merged 4 commits intomainfrom
Conversation
carocao-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rmxyrtfzrr.chromatic.com/ |
JamesBurnside
approved these changes
Apr 28, 2025
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
| > | ||
| <Stack horizontal horizontalAlign="space-between" verticalAlign="center" className={titleContainerClassName}> | ||
| <Text className={titleClassName}>{strings?.captionsSettingsModalTitle}</Text> | ||
| <Text className={titleClassName} role="heading"> |
Member
There was a problem hiding this comment.
This might need to have aria-level as well
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-level#with_heading_role
Contributor
There was a problem hiding this comment.
Good catch, this will need a aria-level @carocao-msft
| > | ||
| <Stack horizontal horizontalAlign="space-between" verticalAlign="center" className={titleContainerClassName}> | ||
| <Text className={titleClassName}>{strings?.realTimeTextModalTitle}</Text> | ||
| <Text role="heading" className={titleClassName}> |
Contributor
There was a problem hiding this comment.
This will need an aria-level
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kftzqqlbfa.chromatic.com/ |
JamesBurnside
approved these changes
Apr 28, 2025
edwardlee-msft
approved these changes
Apr 29, 2025
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-xrkwlkkmdx.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
https://skype.visualstudio.com/SPOOL/_workitems/edit/4111262
Why
How Tested
Process & policy checklist
Is this a breaking change?