Skip to content

Fix for dark text for raise hand button in dark theme#5877

Merged
prabhjot-msft merged 2 commits intomainfrom
prabhjot/dark-text-button-fix
Jun 4, 2025
Merged

Fix for dark text for raise hand button in dark theme#5877
prabhjot-msft merged 2 commits intomainfrom
prabhjot/dark-text-button-fix

Conversation

@prabhjot-msft
Copy link
Copy Markdown
Contributor

What

Before:
Screenshot 2025-06-04 at 2 11 05 PM

After:
Screenshot 2025-06-04 at 2 09 13 PM

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/4045402

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@prabhjot-msft prabhjot-msft requested review from a team as code owners June 4, 2025 21:23
@prabhjot-msft prabhjot-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jun 4, 2025
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jun 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

📦 Chat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 1778427 1778427 ➖ unchanged 0
195.bundle.js 365693 365693 ➖ unchanged 0
450.bundle.js 4452 4452 ➖ unchanged 0
82.bundle.js 28299 28299 ➖ unchanged 0
91.bundle.js 4047 4047 ➖ unchanged 0

Total change: +0 B ➖

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

📦 CallWithChat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 6797824 6798260 ⚠️ increased 436
350.bundle.js 362425 362425 ➖ unchanged 0
398.bundle.js 12413574 12413574 ➖ unchanged 0
450.bundle.js 4468 4468 ➖ unchanged 0
82.bundle.js 28315 28315 ➖ unchanged 0
91.bundle.js 4063 4063 ➖ unchanged 0

Total change: +436 B ⚠️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

📦 Calling bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 5822462 5822904 ⚠️ increased 442
398.bundle.js 12413560 12413560 ➖ unchanged 0

Total change: +442 B ⚠️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29562 / 47140
62.71%
29562 / 47140
62.71%
815 / 1491
54.66%
2419 / 3845
62.91%
Current 29576 / 47154
62.72%
29576 / 47154
62.72%
815 / 1491
54.66%
2419 / 3845
62.91%
Diff 14 / 14
0.01%
14 / 14
0.01%
0 / 0
0%
0 / 0
0%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58287 / 94616
61.6%
58287 / 94616
61.6%
1186 / 2714
43.69%
3384 / 5766
58.68%
Current 58304 / 94628
61.61%
58304 / 94628
61.61%
1186 / 2714
43.69%
3427 / 5790
59.18%
Diff 17 / 12
0.01%
17 / 12
0.01%
0 / 0
0%
43 / 24
0.5%

@prabhjot-msft prabhjot-msft enabled auto-merge (squash) June 4, 2025 23:18
@prabhjot-msft prabhjot-msft merged commit 5d2fd85 into main Jun 4, 2025
66 of 94 checks passed
@prabhjot-msft prabhjot-msft deleted the prabhjot/dark-text-button-fix branch June 4, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants