Skip to content
This repository was archived by the owner on May 11, 2018. It is now read-only.

Add transform-duplicate-keys mapping#192

Merged
existentialism merged 1 commit intomasterfrom
dupe-keys
Mar 6, 2017
Merged

Add transform-duplicate-keys mapping#192
existentialism merged 1 commit intomasterfrom
dupe-keys

Conversation

@existentialism
Copy link
Copy Markdown
Member

@existentialism existentialism commented Mar 6, 2017

Thanks to @Timer, it looks like we missed mapping this transform causing output to be different than preset-latest.

I double checked that the rest of the plugins are mapped.

Ref: facebook/create-react-app#1742

@Timer
Copy link
Copy Markdown

Timer commented Mar 6, 2017

You're a saint. Thanks!

Copy link
Copy Markdown
Member

@yavorsky yavorsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hzoo
Copy link
Copy Markdown
Member

hzoo commented Mar 6, 2017

Oh interesting 😮 . Do we want a test for the output as well?

@yavorsky
Copy link
Copy Markdown
Member

yavorsky commented Mar 6, 2017

@hzoo We are not testing all plugins (just opts for regenerator and transform-polyfill-require-plugin), so I think it's not necessarily. Updating stdout.txt should be ok. Or we could add tests to cover all or most of plugins.
Maybe let's test matching preset-latest without targets?

@Timer
Copy link
Copy Markdown

Timer commented Mar 6, 2017

Anything I can do to help?

@existentialism
Copy link
Copy Markdown
Member Author

Added a quick and dirty sanity check test, it doesn't hurt to have these until we move to more comprehensive tests on Browserstack or some other means.

@existentialism existentialism merged commit e4d0040 into master Mar 6, 2017
@existentialism existentialism deleted the dupe-keys branch March 6, 2017 20:55
This was referenced Mar 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants