This repository was archived by the owner on May 11, 2018. It is now read-only.
Add transform-duplicate-keys mapping#192
Merged
existentialism merged 1 commit intomasterfrom Mar 6, 2017
Merged
Conversation
|
You're a saint. Thanks! |
Member
|
Oh interesting 😮 . Do we want a test for the output as well? |
Member
|
@hzoo We are not testing all plugins (just opts for |
|
Anything I can do to help? |
4cf62b4 to
24e987f
Compare
Member
Author
|
Added a quick and dirty sanity check test, it doesn't hurt to have these until we move to more comprehensive tests on Browserstack or some other means. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @Timer, it looks like we missed mapping this transform causing output to be different than
preset-latest.I double checked that the rest of the plugins are mapped.
Ref: facebook/create-react-app#1742