This repository was archived by the owner on May 17, 2018. It is now read-only.
Add method jumpToOffset()#77
Merged
wyuenho merged 2 commits intobackbone-paginator:masterfrom May 7, 2013
Merged
Conversation
Member
There was a problem hiding this comment.
You are not really "jumping" to an offset, you are getting a page based on an offset. Please change the method name to getPageByOffset.
Member
|
Thanks and apologies for this belated response. This is a very good idea and a good PR. I'll merge as soon as you've fixed these couple of stylistic issues. |
Member
|
Thank you! |
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's convenient to just jump to an offset instead of the page number.
I've added unit tests as well.