cli: Check "NODE_ENV" env var value for config files location#2077
Merged
freben merged 1 commit intobackstage:masterfrom Aug 25, 2020
Merged
cli: Check "NODE_ENV" env var value for config files location#2077freben merged 1 commit intobackstage:masterfrom
freben merged 1 commit intobackstage:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This PR is a follow-up from #1860.
clipackage will considerNODE_ENVenvironment variable to decide which configuration file it will use on itsbuildandservecommands. If the variable is not set, it will fall back to its original behaviour (search forapp-config.production.yamlforbuildandapp-config.development.yamlforserve).✔️ Checklist
yarn test➡️ Well I did runyarn test, but it fail on@backstage/plugin-catalog-backendplugin. I'm not sure if there is a pre-test command that I should have executed or something. Here is a screenshot of the error.Please let me know if there is something I can do about it.
Screenshots attached(no UIs were harmed in the making of this PR 🙂)Relevant documentation updated➡️The documentation already mentioned the usage ofNODE_ENV, so I guess there is no need to update it.