Skip to content

cli: Check "NODE_ENV" env var value for config files location#2077

Merged
freben merged 1 commit intobackstage:masterfrom
MarceloLeite2604:cli
Aug 25, 2020
Merged

cli: Check "NODE_ENV" env var value for config files location#2077
freben merged 1 commit intobackstage:masterfrom
MarceloLeite2604:cli

Conversation

@MarceloLeite2604
Copy link
Copy Markdown
Contributor

Hey, I just made a Pull Request!

This PR is a follow-up from #1860.
cli package will consider NODE_ENV environment variable to decide which configuration file it will use on its build and serve commands. If the variable is not set, it will fall back to its original behaviour (search for app-config.production.yaml for build and app-config.development.yaml for serve).

✔️ Checklist

  • All tests are passing yarn test ➡️ Well I did run yarn test, but it fail on @backstage/plugin-catalog-backend plugin. I'm not sure if there is a pre-test command that I should have executed or something. Here is a screenshot of the error.
    image
    Please let me know if there is something I can do about it.
  • Screenshots attached (no UIs were harmed in the making of this PR 🙂)
  • Relevant documentation updated ➡️The documentation already mentioned the usage of NODE_ENV, so I guess there is no need to update it.
  • Prettier run on changed files
  • Tests added for new functionality ➡️ There were no tests written for these files (Yes, I know this is not an excuse for not writing tests, but I'm still learning React and I'm not fully aware about how to write tests for that. Any help would be really appreciated)
  • Regression tests added for bug fixes ➡️ Please read lame excuse on the item above.

@MarceloLeite2604 MarceloLeite2604 requested a review from a team as a code owner August 21, 2020 21:48
Copy link
Copy Markdown
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@freben freben merged commit 5431f7a into backstage:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants