[patch] Allow log prefixes to be properly disabled when using custom logger#15
Open
felixmc wants to merge 3 commits intobalderdashy:masterfrom
Open
[patch] Allow log prefixes to be properly disabled when using custom logger#15felixmc wants to merge 3 commits intobalderdashy:masterfrom
felixmc wants to merge 3 commits intobalderdashy:masterfrom
Conversation
Member
|
@felixmc is it possible to add a test for that scenario? |
|
👍 |
Member
|
@RWOverdijk see balderdashy/sails#4036 (comment) for more recent discussion on it |
Member
|
Update: I'm leaving this open pending balderdashy/sails#4036 (comment). If anyone would like to do that, please go ahead! |
Contributor
|
@mikermcneil I think this one was pending a change in sails-docs that is already done. Probably can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
issue #14EDIT: Moved to sails#4036.These changes create the following behavior (I made sure to test each scenario described below):
Without a custom logger, everything should work the same, except that it only sets the default prefix if
options.prefixis notfalseornull.With a custom logger and no prefix defined, no prefixes are set and relies on the custom logger to handle its on prefixes (probably preferred behavior with most custom loggers).
With a custom logger and
options.prefixdefined totrueit adds the default prefixes before passing the message to the custom logger (this option might result in duplicate prefixes like described in the issue if the custom logger has its own prefixes, but it would be useful if the custom logger did not have it's own prefixes).With a custom logger and options.prefix is defined as a string, the string prefix is prepended to the message sent to the custom logger.