Use default colorName when configure captains-log#22
Open
leosuncin wants to merge 1 commit intobalderdashy:masterfrom
Open
Use default colorName when configure captains-log#22leosuncin wants to merge 1 commit intobalderdashy:masterfrom
leosuncin wants to merge 1 commit intobalderdashy:masterfrom
Conversation
There's an error when use `captains-log` with Mocha 5, maybe due how mocha mocks/intercepts console logging (I don't know for sure). fixes balderdashy/sails/#4395
leosuncin
changed the title
mikermcneil
added a commit
that referenced
this pull request
Jun 25, 2018
Member
|
@leosuncin thanks! Just to be explicit about this and prevent confusion, I set it up to default to white. |
This was referenced Mar 12, 2020
This was referenced Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an error when use
captains-logwith Mocha 5, maybe due how mocha mocks/intercepts console logging (I don't know for sure).This change doesn't add or modify any current features.
fixes balderdashy/sails/#4395