Conversation
|
Looks good! Any chance of adding a failing test for this? |
|
Sure– would probably be a unit test in this repo, though. I don't know that every adapter could possibly support a binary primary key type. What's the simplest way to get unit tests working alongside the load and integration runners? Edit |
|
Yes, I agree with the unit test. I would say the simplest way is a Makefile like the one in sails-postgresql: https://github.com/balderdashy/sails-postgresql/blob/master/Makefile And then change the package.json accordingly to: "scripts": {
"test": "make test"
}, |
|
Unable to be merged now but seems like it's still a valid issue. I'm so ready for migrations to be their own thing but if this is still an issue for people we should re-submit this. |
|
Will this ever be merged? |
This allows for a user to define a model with a binary type primary key. Resolves #215 . This should be tested before being merged.
CC: @pakalex @dmarcelino @tjwebb