add support for raw query streaming#289
Open
PillowPillow wants to merge 2 commits intobalderdashy:masterfrom
Open
add support for raw query streaming#289PillowPillow wants to merge 2 commits intobalderdashy:masterfrom
PillowPillow wants to merge 2 commits intobalderdashy:masterfrom
Conversation
|
+1 for this. |
|
Problem, your regex makes the query have to contain Removing the regex or expecting a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, like some other peoples, i guess, i needed to stream the result of raw queries.
This pr gives the possibility to perform streaming from raw query by using the where.id criteria if he match the query regex.
I created a temporary adapter for my own usage during this PR or if you don't want to merge it.
https://www.npmjs.com/package/sails-mysql-pillow
Best regards,
Nicolas