[patch] Pull liftTimeout to http hook defaults#7213
Open
DominusKelvin wants to merge 2 commits intobalderdashy:masterfrom
Open
[patch] Pull liftTimeout to http hook defaults#7213DominusKelvin wants to merge 2 commits intobalderdashy:masterfrom
DominusKelvin wants to merge 2 commits intobalderdashy:masterfrom
Conversation
|
Hi @DominusKelvin! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with |
|
Thanks for submitting this pull request, @DominusKelvin! We'll look at it ASAP. In the mean time, here are some ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
Contributor
Author
|
@eashaw just checking if this PR needs any further work to be merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a TODO comment which says to pull the
liftTimeoutdefaulting in thestartServer()function to the hooks definition defaults.