FIX cloneDeep valuesToSet in update blueprints action#7294
Open
AntoineB05 wants to merge 1 commit intobalderdashy:masterfrom
Open
FIX cloneDeep valuesToSet in update blueprints action#7294AntoineB05 wants to merge 1 commit intobalderdashy:masterfrom
AntoineB05 wants to merge 1 commit intobalderdashy:masterfrom
Conversation
|
Thanks for submitting this pull request, @AntoineB05! We'll look at it ASAP. In the mean time, here are some ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I had a problem with the sending of addedTo and removedTo socket notifications when I updated a record with the default update blueprints action. After an investigation, I found the bug was caused by a mutation of the queryOptions.valuesToSet object after the updateOne fonction. I use mongoDB as database. I just added a cloneDeep to prevent the mutation. After the fix, I receive now the addedTo and removedTo socket notifications.
Thanks for your time looking at this
@mikermcneil