Cannot assign `id` property if its not in the fillable array

[baopham]

It was working previously

[baopham]

Due to Model.php class changes for L5.2:

[zoul0813]

Any values being set outside of the model class should be in the $fillable array - not sure this is a bug, or something the package needs to handle.

Ref: https://laracasts.com/discuss/channels/general-discussion/manually-set-id-attribute?page=1

[baopham]

No it's not a bug but because we don't support auto increment id, often that user will need to do $user->id = 'uuid'. Having to put id in $fillable array might be risky if user is not too careful and let id be mass assigned. I'm just putting this here as a reminder.

[zoul0813]

In my project, I set the ID using the event handler mentioned in the laracast.

My Model:

<?php namespace App;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Notifications\Notifiable;
use BaoPham\DynamoDb\DynamoDbModel;
use App\Listeners;

class Listing extends DynamoDbModel
{
    use Notifiable;

    protected $table = "Listings";

    protected $dynamoDbIndexKeys = [
      'listing_index' => [
        'hash' => 'id'
      ],
    ];

    protected $primaryKey = 'id';

    protected $fillable = [
        // fillable fields
    ];
    protected $guarded = ['id'];
}

My Observer:

<?php

namespace App\Listeners;

use App\Listing;
use Webpatser\Uuid\Uuid;
use ElasticSearch;


class ListingObserver {
  public function saved(Listing $listing) {
    // TODO: Index item in ElasticSearch
  }

  public function creating(Listing $listing) {
    $listing->id = Uuid::generate()->string;
  }
}

This works as expected, and is probably the recommended way to do it.

Perhaps put a note in README.md about setting id's explicitly?

[baopham]

Great idea 👍

[zoul0813]

Should this issue be closed, or do you want to update the README and reference the issue?

[baopham]

We can add a FAQ section and reference this issue. I'll do that later.

[bubba-h57]

More elegantly, you can simply add

protected static function boot()
    {
        parent::boot();

        static::creating(function (User $user) {
            $user->identity = Uuid::uuid4()->toString();
        });
    }

to your User class, making it handle it's own event.

[zoul0813]

Unfortunately though, you can’t mock that and generate consistent ID values for your test environment.

[bubba-h57]

I suppose we should point out that you could also just put a generator object in the IOC and pull it out of there to use it as well.

[bubba-h57]

Oh ... well pft. Apparently you do not really have to do all of that and you can mock the Uuid::uuid4() method directly.

<?php
use PHPUnit\Framework\TestCase;
use Ramsey\Uuid\Uuid;
use Ramsey\Uuid\UuidFactory;

class UuidMockTest extends TestCase
{
    public function testKnownUuidByMockingFactory()
    {
        // Create a Uuid object from a known UUID string
        $stringUuid = '253e0f90-8842-4731-91dd-0191816e6a28';
        $uuid = Uuid::fromString($stringUuid);

        // Partial mock of the factory;
        // returns $uuid object when uuid4() is called.
        $factoryMock = \Mockery::mock(UuidFactory::class . '[uuid4]', [
            'uuid4' => $uuid,
        ]);

        // Replace the default factory with our mock
        Uuid::setFactory($factoryMock);

        // Uuid::uuid4() is a proxy to the $factoryMock->uuid4() method, so
        // when Uuid::uuid4() is called, it calls the mocked method on the
        // factory and returns a valid Uuid object that we have defined.
        $this->assertSame($uuid, Uuid::uuid4());
        $this->assertEquals($stringUuid, Uuid::uuid4()->toString());
    }

    /**
     * @runInSeparateProcess
     * @preserveGlobalState disabled
     */
    public function testMockStaticUuidMethodToReturnKnownString()
    {
        // We replace the Ramsey\Uuid\Uuid class with one created by Mockery
        // (using the "alias:" prefix) so that we can mock the static uuid4()
        // method. For this to work without affecting the Ramsey\Uuid\Uuid
        // class used by other tests, we must run this in a separate process
        // with preserveGlobalState disabled (see method annotations).
        \Mockery::mock('alias:' . Uuid::class, [
            'uuid4' => 'uuid-baz',
        ]);

        // We've replaced Ramsey\Uuid\Uuid with our own class that defines the
        // method uuid4(). This method returns the string "uuid-baz."
        $this->assertEquals('uuid-baz', Uuid::uuid4());
    }
}

ramsey/uuid#147 (comment)