Added option to remove comment about interface referencer#575
Open
Stmated wants to merge 2 commits intobcherny:masterfrom
Open
Added option to remove comment about interface referencer#575Stmated wants to merge 2 commits intobcherny:masterfrom
Stmated wants to merge 2 commits intobcherny:masterfrom
Conversation
bcherny
requested changes
Mar 2, 2024
Owner
bcherny
left a comment
bcherny
left a comment
There was a problem hiding this comment.
Thanks for the contribution, but I'm not sure this change is worth the added complexity it introduces. We can revisit if there is significant interest from others (please feel welcome to open an issue).
Author
You know what would bring even less complexity? Just removing the comment without any setting of enabling it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating code using
unreachableDefinitionsit adds a comment to the interface statingThis interface was referenced by....I find this quite annoying. So I added an option to not include those comments.