feat: Add removeOptionalIfDefaultExists option#673
Open
sortA0329 wants to merge 2 commits intobcherny:masterfrom
Open
feat: Add removeOptionalIfDefaultExists option#673sortA0329 wants to merge 2 commits intobcherny:masterfrom
removeOptionalIfDefaultExists option#673sortA0329 wants to merge 2 commits intobcherny:masterfrom
Conversation
|
Perfect timing! Would love to have this in place! |
calleli
added a commit
to calleli/json-schema-to-typescript
that referenced
this pull request
Oct 28, 2025
|
When will this be merged and released? |
I forked the repo and brought in this functionality and then installed it using patch-package. It does the trick for me in the meantime. |
Author
|
I'd left this PR hanging since I no longer needed it, but it looks like there's more demand for it than I expected. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #558
This PR adds a new option,
removeOptionalIfDefaultExists, which allows the code generator to omit the optional modifier for properties that have a default value in the JSON Schema. The enhancement includes updates to the CLI, documentation, and core parsing logic, and is covered by new end-to-end tests.