Skip to content

Add windows terminal resizing#80

Merged
bczsalba merged 1 commit intobczsalba:masterfrom
Tired-Fox:master
Jul 21, 2022
Merged

Add windows terminal resizing#80
bczsalba merged 1 commit intobczsalba:masterfrom
Tired-Fox:master

Conversation

@Tired-Fox
Copy link
Copy Markdown
Contributor

@Tired-Fox Tired-Fox commented Jul 20, 2022 •
edited
Loading

Fix for Issue #33 relating to proposed fix here.

  • Add function with an infinite loop that checks for a terminal resize and calls _update_size
  • Add else condition to if hasattr(signal, "SIGWINCH") that starts a new thread

bczsalba
bczsalba reviewed Jul 21, 2022
View reviewed changes
Copy link
Copy Markdown
Owner

@bczsalba bczsalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bczsalba bczsalba merged commit 3e484df into bczsalba:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bczsalba bczsalba bczsalba left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REQUEST] Support SIGWINCH on Windows

2 participants

@Tired-Fox @bczsalba
⚡